https://legacy.forums.gravityhelp.com/topic/code-improvements-double-title-attribute-insert-id Gravity Support Forums Topic: Code improvements: double title attribute, insert ID en-US Sat, 04 Apr 2026 07:43:36 +0000 http://bbpress.org/?v=1.0.1 q https://legacy.forums.gravityhelp.com/search.php https://legacy.forums.gravityhelp.com/topic/code-improvements-double-title-attribute-insert-id#post-28766 Wed, 29 Jun 2011 03:40:51 +0000 pronamic 28766@https://legacy.forums.gravityhelp.com/ <p>Just some tips / improvements... in version 1.2.3 of the PayPal Add-On:</p> <p>paypal.php on line 370:</p> <pre><code>&lt;span class=&quot;edit&quot;&gt; &lt;a title=&quot;&lt;?php _e(&quot;Edit&quot;, &quot;gravityformspaypal&quot;)?&gt;&quot; href=&quot;admin.php?page=gf_paypal&amp;view=edit&amp;id=&lt;?php echo $setting[&quot;id&quot;] ?&gt;&quot; title=&quot;&lt;?php _e(&quot;Edit&quot;, &quot;gravityformspaypal&quot;) ?&gt;&quot;&gt;&lt;?php _e(&quot;Edit&quot;, &quot;gravityformspaypal&quot;) ?&gt;&lt;/a&gt; | &lt;/span&gt; &lt;a title=&quot;&lt;?php _e(&quot;View Stats&quot;, &quot;gravityformspaypal&quot;)?&gt;&quot; href=&quot;admin.php?page=gf_paypal&amp;view=stats&amp;id=&lt;?php echo $setting[&quot;id&quot;] ?&gt;&quot; title=&quot;&lt;?php _e(&quot;View Stats&quot;, &quot;gravityformspaypal&quot;) ?&gt;&quot;&gt;&lt;?php _e(&quot;Stats&quot;, &quot;gravityformspaypal&quot;) ?&gt;&lt;/a&gt; | &lt;/span&gt; &lt;a title=&quot;&lt;?php _e(&quot;View Entries&quot;, &quot;gravityformspaypal&quot;)?&gt;&quot; href=&quot;admin.php?page=gf_entries&amp;view=entries&amp;id=&lt;?php echo $setting[&quot;form_id&quot;] ?&gt;&quot; title=&quot;&lt;?php _e(&quot;View Entries&quot;, &quot;gravityformspaypal&quot;) ?&gt;&quot;&gt;&lt;?php _e(&quot;Entries&quot;, &quot;gravityformspaypal&quot;) ?&gt;&lt;/a&gt; | &lt;/span&gt; &lt;span class=&quot;edit&quot;&gt; &lt;a title=&quot;&lt;?php _e(&quot;Delete&quot;, &quot;gravityformspaypal&quot;) ?&gt;&quot; href=&quot;javascript: if(confirm(&#39;&lt;?php _e(&quot;Delete this feed? &quot;, &quot;gravityformspaypal&quot;) ?&gt; &lt;?php _e(&quot;\&#39;Cancel\&#39; to stop, \&#39;OK\&#39; to delete.&quot;, &quot;gravityformspaypal&quot;) ?&gt;&#39;)){ DeleteSetting(&lt;?php echo $setting[&quot;id&quot;] ?&gt;);}&quot;&gt;&lt;?php _e(&quot;Delete&quot;, &quot;gravityformspaypal&quot;)?&gt;&lt;/a&gt; &lt;/span&gt;</code></pre> <p>The "title" attribute is often specified twice. There is missing an opening "span" tag just before the "View Entries" link. I think the &lt;span&gt; element wrapped around the "Delete" link should be classifcied as "trash", and the &lt;span&gt; around the "View Entries" link as "view".</p> <p>data.php on line 169:</p> <p><code>$id = $wpdb-&gt;get_var(&quot;SELECT LAST_INSERT_ID()&quot;);</code></p> <p>Why don't you use the code:</p> <p><code>$id = $wpdb-&gt;insert_id;</code></p> <p><a href="http://codex.wordpress.org/Function_Reference/wpdb_Class#INSERT_rows" rel="nofollow">http://codex.wordpress.org/Function_Reference/wpdb_Class#INSERT_rows</a></p> <p>I guess these improvements also apply to other Add-Ons. </p>