https://legacy.forums.gravityhelp.com/topic/slow-form-submission-26k-draft-posts-function-improvement-request Gravity Support Forums Topic: Slow form submission - 26k+ draft posts - function improvement request en-US Sun, 19 Apr 2026 18:28:05 +0000 http://bbpress.org/?v=1.0.1 q https://legacy.forums.gravityhelp.com/search.php https://legacy.forums.gravityhelp.com/topic/slow-form-submission-26k-draft-posts-function-improvement-request#post-373087 Wed, 10 Jul 2013 08:23:46 +0000 Rob Harrell 373087@https://legacy.forums.gravityhelp.com/ <p>Dev team has added this to Pivotal Tracker for discussion. </p> https://legacy.forums.gravityhelp.com/topic/slow-form-submission-26k-draft-posts-function-improvement-request#post-371700 Tue, 09 Jul 2013 17:25:31 +0000 MarketplaceHomes 371700@https://legacy.forums.gravityhelp.com/ <p>Thanks much!</p> <p>Gravity forms works very nicely, but the cycling through all current posts with 26k records was getting to be a showstopper as it was causing submissions to take almost 30 seconds. </p> https://legacy.forums.gravityhelp.com/topic/slow-form-submission-26k-draft-posts-function-improvement-request#post-371553 Tue, 09 Jul 2013 15:41:37 +0000 Rob Harrell 371553@https://legacy.forums.gravityhelp.com/ <p>I'll bring this up to the dev team. </p> https://legacy.forums.gravityhelp.com/topic/slow-form-submission-26k-draft-posts-function-improvement-request#post-371549 Tue, 09 Jul 2013 15:40:43 +0000 MarketplaceHomes 371549@https://legacy.forums.gravityhelp.com/ <p>Just a quick followup to note that I did what I recommended above to our copy of gravity forms and the result speaks for itself:</p> <p>26K draft posts ( from gravity forms ).</p> <p>Original processing time for form submissions: 26-28 seconds</p> <p>New processing time for form submissions: 2-3 seconds</p> <p>Here is the re-written code ( it could be done differently ) with my debug code and error handling taken out:</p> <pre><code>private static function get_default_post_title(){ global $wpdb; # A default to use for the final title to return $final_title = &#39;Untitled_1&#39;; # Grab the most recent post that has Untitled_* $sql = &quot;SELECT ID, post_title FROM {$wpdb-&gt;posts} WHERE post_title like &#39;Untitled\_%&#39; ORDER BY post_date DESC LIMIT 0, 1&quot;; $results = $wpdb-&gt;get_results( $sql, ARRAY_A ); if ( !is_null($results) ) { # found a match if ( is_array($results) ) { if ( count($results) &gt; 0 ) { $match = array_pop($results); $found_title = $match[&#39;post_title&#39;]; $wanted_part = str_replace(&#39;Untitled_&#39;, &#39;&#39;, $found_title); $wanted_part = (int)$wanted_part; if ( $wanted_part &gt; 0 ) { # we successfully found the wanted Untitled entry $wanted_part += 1; } else { # non numeric Untitled_* - start with the post ID + 1 when doing checks $wanted_part = (int)$match[&#39;ID&#39;] + 1; } # Update the default title $final_title = &quot;Untitled_{$wanted_part}&quot;; # Set up our early break flag $done_with_loop = false; # Check for existence of the wanted part ( up to 100 times ) # - still much faster than looping 26k times for ( $i = 0; $i &lt; 100; $i++ ) { $sql = &quot;SELECT 1 as &lt;code&gt;it_exists&lt;/code&gt; FROM {$wpdb-&gt;posts} WHERE post_title = &#39;Untitled_{$wanted_part}&#39;&quot;; $exists = $wpdb-&gt;get_results( $sql, ARRAY_A ); if ( is_null($exists) ) { # no results returned if ( !empty( $wpdb-&gt;last_error ) ) { # Error with query } else { # simply not found $final_title = &quot;Untitled_{$wanted_part}&quot;; $done_with_loop = true; } } else { if ( is_array($exists) &amp;&amp; count($exists) &gt; 0 ) { $test = array_pop($exists); if ( &#39;1&#39; == &quot;{$test[&#39;it_exists&#39;]}&quot; ) { # this exists - try the next item $wanted_part += 1; } else { # does not exist - good to go $final_title = &quot;Untitled_{$wanted_part}&quot;; $done_with_loop = true; } } else { # no matches found $final_title = &quot;Untitled_{$wanted_part}&quot;; $done_with_loop = true; } } if ( $done_with_loop ) { break; } } } else { # no match found for Untitled_* in the system # - should not happen - treat as an error } } else { # not an array # - should not happen - treat as error } } else { # no results at all likely an error if ( !empty($wpdb-&gt;last_error) ) { # database call error } else { # null result but no last error } } return $final_title; }</code></pre> <p>Rewriting this function in the core code base would be greatly appreciated by those of us with much larger recordsets. </p> https://legacy.forums.gravityhelp.com/topic/slow-form-submission-26k-draft-posts-function-improvement-request#post-369370 Mon, 08 Jul 2013 21:37:21 +0000 MarketplaceHomes 369370@https://legacy.forums.gravityhelp.com/ <p>Hello,</p> <p>We are running quite a few Gravity Forms forms and form submissions have slowed down significantly over time.</p> <p>I wrote a timer utility to check and see which part of the process was taking so much extra time and was a bit surprised to see that the actual entry creation was taking 26+ seconds per form submission.</p> <p>After a bit of digging, I narrowed the culprit down ( gravity forms 1.7.6 ) to the forms_model.php file, get_default_post_title function.</p> <p>Currently it looks like the following:</p> <pre><code>private static function get_default_post_title(){ global $wpdb; $title = &quot;Untitled&quot;; $count = 1; $titles = $wpdb-&gt;get_col(&quot;SELECT post_title FROM $wpdb-&gt;posts WHERE post_title like &#39;%Untitled%&#39;&quot;); $titles = array_values($titles); while(in_array($title, $titles)){ $title = &quot;Untitled_$count&quot;; $count++; } return $title; }</code></pre> <p>With 25000 records that match, a procedural language approach ( like C, C++, php, etc. ) will take a good long while to run through the loop and find an untaken value.</p> <p>It would be much better to use a set language approach ( sql ) which might look like the following:</p> <ol> <li>Grab the ID ( or title ) of the most recently added post</li> <li>Add one to the ID ( or parse the title, grab the integer, and increment it )</li> <li>Set the title to Untitled_N where N is the result of the integer found + 1</li> <li>If needed, use a small loop to check for existence of a post having that title, and increment the integer until an unused title is found</li> <li>return the resulting title</li> </ol> <p>Doing things this way would save a ton of processing power and time, and the fix would be rather simple.</p> <p>Obviously, it would be even better to use a custom post type for these things as that would avoid cluttering the post list with tons of drafts, allow full control over title generation ( e.g. with your own custom post type you could be certain the next unused id was available for use as a title ), etc. But that would also take a lot more work, especially to maintain backward compatibility.</p> <p>Anywise, if you could take a look at that function and revise it so that it doesn't bog larger systems down, it would be much appreciated. </p>